Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2497][VEN-2498]: XVS and XVSBridge deployment on Arbitrum Sepolia #25

Merged
merged 13 commits into from
Apr 25, 2024
Merged

[VEN-2497][VEN-2498]: XVS and XVSBridge deployment on Arbitrum Sepolia #25

merged 13 commits into from
Apr 25, 2024

Conversation

Debugger022
Copy link
Contributor

Description

Resolves #VEN-2497 and VEN-2498

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@Debugger022 Debugger022 requested review from chechu and GitGuru7 March 26, 2024 10:14
@Debugger022 Debugger022 self-assigned this Mar 28, 2024
0xlucian
0xlucian previously approved these changes Apr 6, 2024
View reviewed changes
chechu
chechu reviewed Apr 17, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
helpers/deploymentConfig.ts Show resolved Hide resolved
helpers/deploymentConfig.ts Show resolved Hide resolved
chechu
chechu previously approved these changes Apr 17, 2024
View reviewed changes
@chechu chechu dismissed their stale review April 17, 2024 11:10

Pending comments

@Debugger022 Debugger022 mentioned this pull request Apr 17, 2024
Merged
4 tasks
@Debugger022 Debugger022 requested a review from chechu April 17, 2024 14:01
chechu
chechu reviewed Apr 17, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@Debugger022 Debugger022 requested review from chechu and 0xlucian April 18, 2024 06:05
chechu
chechu previously approved these changes Apr 18, 2024
View reviewed changes
chechu
chechu previously approved these changes Apr 23, 2024
View reviewed changes
0xlucian
0xlucian previously approved these changes Apr 24, 2024
View reviewed changes
chechu
chechu reviewed Apr 24, 2024
View reviewed changes
helpers/deploymentConfig.ts Outdated Show resolved Hide resolved
@Debugger022 Debugger022 dismissed stale reviews from 0xlucian and chechu via 345f9bb April 24, 2024 10:27
@Debugger022 Debugger022 requested a review from chechu April 24, 2024 10:32
chechu
chechu previously approved these changes Apr 24, 2024
View reviewed changes
@Debugger022 Debugger022 requested a review from chechu April 25, 2024 06:16
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
Bridge 94% 85% ✔
Bridge.interfaces 100% 100% ✔
Bridge.token 97% 83% ✔
Summary 95% (225 / 237) 85% (112 / 132) ✔

@Debugger022 Debugger022 merged commit d678df8 into develop Apr 25, 2024
4 checks passed
@chechu chechu mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@0xlucian 0xlucian 0xlucian left review comments

@GitGuru7 GitGuru7 Awaiting requested review from GitGuru7

Assignees

@Debugger022 Debugger022

Labels
arbitrum sepolia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Debugger022 @chechu @0xlucian